grundprinzip commented on code in PR #49529:
URL: https://github.com/apache/spark/pull/49529#discussion_r1919113055
##########
sql/connect/common/src/main/protobuf/spark/connect/ml.proto:
##########
@@ -84,7 +85,7 @@ message MlCommand {
message MlCommandResult {
oneof result_type {
// The result of the attribute
- Param param = 1;
+ Expression param = 1;
Review Comment:
I think the unification to Expression is the right direction, but we don't
support all Expressions, but only Expression.Literal, I would prefer changing
it to Literal here to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
