grundprinzip commented on code in PR #49529:
URL: https://github.com/apache/spark/pull/49529#discussion_r1919114135
##########
sql/connect/common/src/main/protobuf/spark/connect/ml_common.proto:
##########
@@ -28,17 +28,7 @@ option go_package = "internal/generated";
// MlParams stores param settings for ML Estimator / Transformer / Evaluator
message MlParams {
// User-supplied params
- map<string, Param> params = 1;
-}
-
-// Represents the parameter type of the ML instance, or the returned value
-// of the attribute
-message Param {
- oneof param_type {
- Expression.Literal literal = 1;
- Vector vector = 2;
- Matrix matrix = 3;
- }
+ map<string, Expression> params = 1;
Review Comment:
similar
##########
sql/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -151,7 +151,7 @@ message Fetch {
message Args {
oneof args_type {
- Param param = 1;
+ Expression param = 1;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
