chenhao-db commented on PR #49627: URL: https://github.com/apache/spark/pull/49627#issuecomment-2610554600
`PushVariantIntoScanSuite` is failing due to the change - it only recognizes `VariantGet`, but not the replaced expression (replacing runtime-replaceable expression happens before the rule). Essentially, I don't really think this change is a good idea. The implementation of `VariantGet` is simplified only by a bit, which is fixed and not likely to change, but the optimizer rules will get more complex (and there may be more rules targeting `VariantGet` in the future). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
