cloud-fan commented on code in PR #49627:
URL: https://github.com/apache/spark/pull/49627#discussion_r1928162633
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PushVariantIntoScan.scala:
##########
@@ -244,6 +272,24 @@ class VariantInRelation {
// Rewrite the attribute in advance, rather than depending on the last
branch to rewrite it.
// Ww need to avoid the `v@StructPathToVariant(fields)` branch to
rewrite the child again.
GetStructField(rewriteAttribute(v), fields(RequestedVariantField(g)))
+ case s @ StaticInvoke(
Review Comment:
This is likely the most annoying part of `RuntimeReplaceable`: pattern match
becomes less intuitive.
Now I think it's probably better not to use `RuntimeReplaceable` for
expressions that need be matched post analysis, until we improve
`RuntimeReplaceable` to be replaced truly at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
