cloud-fan commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1928122823
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionContext.scala:
##########
@@ -20,19 +20,23 @@ package org.apache.spark.sql.scripting
import scala.collection.mutable.ListBuffer
import org.apache.spark.SparkException
+import
org.apache.spark.sql.scripting.SqlScriptingFrameType.SqlScriptingFrameType
/**
* SQL scripting execution context - keeps track of the current execution
state.
*/
class SqlScriptingExecutionContext {
// List of frames that are currently active.
- val frames: ListBuffer[SqlScriptingExecutionFrame] = ListBuffer.empty
+ private[scripting] val frames: ListBuffer[SqlScriptingExecutionFrame] =
ListBuffer.empty
Review Comment:
not related to this PR, but can we add more comments to explain the concepts
(frame, scope)? we should also try to map them to the user-facing concepts:
single statement, compound statement (BEGIN END), error hander statement,
nested stored procedure, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
