davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1928367480
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SqlScriptingLogicalPlans.scala:
##########
@@ -327,15 +327,62 @@ object HandlerType extends Enumeration {
val EXIT, CONTINUE = Value
}
+/**
+ * Class holding information about what triggers the handler.
+ * @param sqlStates Name of the error condition.
+ * @param conditions SQLSTATE or Error Code.
+ * @param sqlException Flag indicating if the handler is triggered by
SQLEXCEPTION.
+ * @param notFound Flag indicating if the handler is triggered by NOT FOUND.
+ */
+class HandlerTriggers(
Review Comment:
I think we have too much different namings related to handlers in the code -
somewhere it's an "error handler", somewhere an "exception handler" and
somewhere just a "handler". I think we should unify the namings and to me the
"ExceptionHandler" sounds the best.
In that light, I would name this "ExceptionHandlerTriggers".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
