wayneguow commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1929715837
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala:
##########
@@ -228,8 +228,8 @@ private case class OracleDialect() extends JdbcDialect with
SQLConfHelper with N
extends JdbcSQLQueryBuilder(dialect, options) {
override def build(): String = {
- val selectStmt = s"SELECT $columnList FROM ${options.tableOrQuery}
$tableSampleClause" +
- s" $whereClause $groupByClause $orderByClause"
+ val selectStmt = s"SELECT $hintClause$columnList FROM
${options.tableOrQuery}" +
Review Comment:
The reason why I don't add a space here is because if the hint is "", for
other JDBCDialects that do not support hints, there will be one more space here
than before. But for normal hints, when processing the hint content in
`JDBCOptions`, a space has been added at the end.
`s"$value "`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
