beliefer commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1929757747


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -980,6 +980,13 @@ private[sql] object QueryExecutionErrors extends 
QueryErrorsBase with ExecutionE
       messageParameters = Map("content" -> content))
   }
 
+  def hintUnsupportedForJdbcDialectError(
+      jdbcDialect: String): SparkUnsupportedOperationException = {
+    new SparkUnsupportedOperationException(

Review Comment:
   Please use `SparkIllegalArgumentException` here.
   Its an option error.



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -980,6 +980,13 @@ private[sql] object QueryExecutionErrors extends 
QueryErrorsBase with ExecutionE
       messageParameters = Map("content" -> content))
   }
 
+  def hintUnsupportedForJdbcDialectError(
+      jdbcDialect: String): SparkUnsupportedOperationException = {
+    new SparkUnsupportedOperationException(

Review Comment:
   Please use `SparkIllegalArgumentException` here.
   It's an option error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to