Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6479#discussion_r31683772
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratePredicate.scala
 ---
    @@ -20,10 +20,16 @@ package 
org.apache.spark.sql.catalyst.expressions.codegen
     import org.apache.spark.sql.catalyst.expressions._
     
     /**
    + * Interface for generated predicate
    + */
    +trait Predicate {
    --- End diff --
    
    Should this be an abstract base class instead of a trait?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to