Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6479#discussion_r31684243
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -125,32 +139,45 @@ abstract class CodeGenerator[InType <: AnyRef, 
OutType <: AnyRef] extends Loggin
        * @param objectTerm A possibly boxed version of the result of 
evaluating this expression.
        */
       protected case class EvaluatedExpression(
    -      code: Seq[Tree],
    -      nullTerm: TermName,
    -      primitiveTerm: TermName,
    -      objectTerm: TermName)
    +      code: String,
    +      nullTerm: String,
    +      primitiveTerm: String,
    +      objectTerm: String)
    +
    +  /**
    +   * A context for codegen
    +   * @param references the expressions that don't support codegen
    --- End diff --
    
    Can you elaborate a bit more on this?  How do things get stored into this 
list and when do they get read back?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to