dongjoon-hyun commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1929913772
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala:
##########
@@ -228,8 +228,8 @@ private case class OracleDialect() extends JdbcDialect with
SQLConfHelper with N
extends JdbcSQLQueryBuilder(dialect, options) {
override def build(): String = {
- val selectStmt = s"SELECT $columnList FROM ${options.tableOrQuery}
$tableSampleClause" +
- s" $whereClause $groupByClause $orderByClause"
+ val selectStmt = s"SELECT $hintClause$columnList FROM
${options.tableOrQuery}" +
Review Comment:
Ur, @beliefer . I'd prefer not to add a space with a different reason.
The reason is that HINT is very exceptional use cases. I believe 99% queries
will not have this hint option. And, we don't want to add an extra space into
our SELECT statement here. It's a kind of regression without any benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
