ericm-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1941548766
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,25 @@ class DriverStatefulProcessorHandleImpl(timeMode:
TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ private def isInternal(columnFamilyName: String): Boolean = {
+ columnFamilyName.startsWith("_") || columnFamilyName.startsWith("$")
+ }
+
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable &&
!isInternal(colFamilyName)) {
Review Comment:
We need to treat them differently because the schemas for these are
non-nullable by default. We can either change the schemas for them to be
nullable or have this check, what do you think is the best solution?
I think this check makes the most sense but am open to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
