ericm-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945307417
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -364,17 +364,20 @@ class DriverStatefulProcessorHandleImpl(timeMode:
TimeMode, keyExprEnc: Expressi
}
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable) {
+ throw StateStoreErrors.stateStoreSchemaMustBeNullable(
+ schema.colFamilyName, schema.valueSchema.toString())
+ }
}
- } else {
- schemas
+ colFamilyName -> schema.copy(
Review Comment:
Yeah, it is. Encoders.product automatically sets schema as non-nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
