miland-db commented on code in PR #49726: URL: https://github.com/apache/spark/pull/49726#discussion_r1944467073
########## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala: ########## @@ -1020,3 +1023,105 @@ class ExceptionHandlerExec( override def reset(): Unit = body.reset() } + +/** + * Executable node for Signal Statement. + * @param errorCondition Name of the error condition/SQL State for error that will be thrown. + * @param sqlState SQL State of the error that will be thrown. + * @param message Error message (either string or variable name). + * @param msgArguments Error message parameters for builtin conditions. + * @param session Spark session that SQL script is executed within. + */ +class SignalStatementExec( + val errorCondition: Option[String] = None, + val sqlState: Option[String] = None, + val message: Either[String, UnresolvedAttribute], + val msgArguments: Option[UnresolvedAttribute], Review Comment: @srielau suggested that for the first version providing the variable that holds the map of arguments is enough. Next steps will be to add support for other ways to specify message arguments, e.g. directly using `map(...)` function etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
