MaxGekk commented on code in PR #49726:
URL: https://github.com/apache/spark/pull/49726#discussion_r1944495189
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -3602,6 +3602,12 @@
],
"sqlState" : "42K09"
},
+ "INVALID_VARIABLE_TYPE_FOR_SIGNAL_STATEMENT" : {
+ "message" : [
+ "Variable type must be Map<String, String> type but got <varType>."
Review Comment:
Could you output `Map<String, String>` in the same way as `toSQLType`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SqlScriptingLogicalPlans.scala:
##########
@@ -405,3 +406,25 @@ case class ExceptionHandler(
handlerType)
}
}
+
+/**
+ * Logical operator for Signal Statement.
+ * @param isBuiltinError Flag indicating if the error is a builtin error.
+ * @param errorCondition Name of the error condition/SQL State for error that
will be thrown.
Review Comment:
`condition/SQL State` is it a mix of `condition` and `sqlState`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
