dejankrak-db commented on code in PR #49772:
URL: https://github.com/apache/spark/pull/49772#discussion_r1945871779
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultStringTypes.scala:
##########
@@ -47,7 +46,7 @@ object ResolveDefaultStringTypes extends Rule[LogicalPlan] {
if (isDDLCommand(plan)) {
transformDDL(plan)
} else {
- transformPlan(plan, sessionDefaultStringType)
Review Comment:
@stefankandic kindly helped refactor this code to remove all
unnecessary/unused references, but we still need to do transform plan for DML
statements using the default string type which is now UTF8_BINARY, and the
apply method logic is still needed to ensure correct results where default
string type is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
