dejankrak-db commented on code in PR #49772:
URL: https://github.com/apache/spark/pull/49772#discussion_r1947986882
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultStringTypes.scala:
##########
@@ -47,7 +46,7 @@ object ResolveDefaultStringTypes extends Rule[LogicalPlan] {
if (isDDLCommand(plan)) {
transformDDL(plan)
} else {
- transformPlan(plan, sessionDefaultStringType)
Review Comment:
@cloud-fan, I have added DDL collation resolution in the latest iteration,
as well as a test cases that validate that the object level collation is
propagated to underlying columns accordingly.
I believe the rule has its purpose now, which is to do DDL collation
resolution for DDL queries, as well as to apply default UTF8_binary collation
for DML queries (although previously applied object level collation will take
precedence)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
