zhengruifeng commented on code in PR #49879:
URL: https://github.com/apache/spark/pull/49879#discussion_r1950607194
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -1162,7 +1162,16 @@ object functions {
* @group agg_funcs
* @since 4.0.0
*/
- def listagg(e: Column, delimiter: Column): Column = Column.fn("listagg", e,
delimiter)
+ def listagg(e: Column, delimiter: String): Column = Column.fn("listagg", e,
lit(delimiter))
Review Comment:
I think it is good to have `def listagg(e: Column, delimiter: String)`, but
I also want to keep `def listagg(e: Column, delimiter: Column)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
