zhengruifeng commented on code in PR #49879: URL: https://github.com/apache/spark/pull/49879#discussion_r1950652745
########## python/pyspark/sql/functions/builtin.py: ########## @@ -1853,7 +1853,7 @@ def sum_distinct(col: "ColumnOrName") -> Column: @_try_remote_functions -def listagg(col: "ColumnOrName", delimiter: Optional[Union[Column, str, bytes]] = None) -> Column: Review Comment: currently yes, I see `delimiter` in other expressions canbe unfoldable, e.g. `split_part`. https://github.com/apache/spark/blob/1ba759feb7849d847be79de972383097c0d3f28b/sql/api/src/main/scala/org/apache/spark/sql/functions.scala#L52-L54 According to this guide, a function should always accept Column input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
