liviazhu-db commented on code in PR #50030: URL: https://github.com/apache/spark/pull/50030#discussion_r1968325595
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala: ########## @@ -419,6 +433,10 @@ private[sql] class HDFSBackedStateStoreProvider extends StateStoreProvider with private val loadedMapCacheHitCount: LongAdder = new LongAdder private val loadedMapCacheMissCount: LongAdder = new LongAdder + // This is updated when the maintenance task writes the snapshot file, -1 represents no version + // has ever been uploaded. + private var lastSnapshotUploadedVersion: Long = -1L Review Comment: Does this not need to be an AtomicLong, since maintenance thread will modify it and task thread will read it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
