zecookiez commented on PR #50030: URL: https://github.com/apache/spark/pull/50030#issuecomment-2696799664
@HeartSaVioR There are two non-test main differences compared to the RocksDB PR: - Add tracking of `lastSnapshotUploadedVersion` to HDFS state stores, which is updated in the state store object instead of RocksDB. Also updates at the end of `writeUpdates` instead of `uploadSnapshot`. - Metric creation is done in the state store provider class instead of object As for the test changes: - Modified the RocksDB tests slightly to process some additional data in the queries, because the version difference check used in HDFS and RocksDB state stores uses `>` and `>=` respectively. The general structure of the tests remain the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
