srowen commented on code in PR #50020:
URL: https://github.com/apache/spark/pull/50020#discussion_r1981390437
##########
core/src/main/scala/org/apache/spark/BarrierCoordinator.scala:
##########
@@ -80,8 +81,9 @@ private[spark] class BarrierCoordinator(
states.forEachValue(1, clearStateConsumer)
states.clear()
listenerBus.removeListener(listener)
- ThreadUtils.shutdown(timer)
} finally {
+ timerFuture.foreach(_.cancel(true))
+ ThreadUtils.shutdown(timer)
Review Comment:
But, if `newSingleThreadScheduledExecutor` creates daemon threads, then this
doesn't stop the JVM exit.
You don't really care if this process runs or not at shutdown.
This is part of why I don't quite understand this change - it's about daemon
threads, but you're not changing the daemon status of the thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
