jjayadeep06 commented on PR #50020: URL: https://github.com/apache/spark/pull/50020#issuecomment-2699707030
> I still don't see how this addresses the non-daemon thread hanging around. Wouldn't we need to make some executor use daemon threads somewhere? This code below setups the timertask as a `Non Daemon` thread which does not exits when the JVM exits, the details is available https://github.com/apache/spark/pull/47956#issuecomment-2328035086. ``` timerFuture = Some(timer.schedule(timerTask, timeoutInSecs, TimeUnit.SECONDS)) ``` This PR makes use of the correct APIs of [Future.cancel(boolean)](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/concurrent/Future.html) to cancel the non daemon thread (timerTask) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
