pan3793 commented on code in PR #50378: URL: https://github.com/apache/spark/pull/50378#discussion_r2013394875
########## dev/create-release/release-tag.sh: ########## @@ -106,6 +106,8 @@ sed -i".tmp7" 's/SPARK_VERSION:.*$/SPARK_VERSION: '"$NEXT_VERSION"'/g' docs/_con sed -i".tmp8" 's/SPARK_VERSION_SHORT:.*$/SPARK_VERSION_SHORT: '"$R_NEXT_VERSION"'/g' docs/_config.yml # Update the version index of DocSearch as the short version sed -i".tmp9" "s/'facetFilters':.*$/'facetFilters': [\"version:$R_NEXT_VERSION\"]/g" docs/_config.yml +# Remove test jars that do not beling to source releases. +rm $(<dev/test-jars.txt) Review Comment: but the tag also belongs to the release branch, e.g. branch-4.0, then all commits after this tag do not have the jars, and it affects code repo too. Currently, Spark clones the repo and uses shell commands like `rm`, `tar`, to create the source release tarball, https://github.com/apache/spark/blob/3ffb8009a3d660f25b4d003d0e702d60e8527ab6/dev/create-release/release-build.sh#L263 I think the simplest way is to replace it with `git archive`, with a `.gitattributes` to define the excluded files, e.g. https://github.com/apache/kyuubi/blob/176bc293fc142b3b9bf07dddd40e525072905efb/build/release/create-package.sh#L61 https://github.com/apache/kyuubi/blob/176bc293fc142b3b9bf07dddd40e525072905efb/.gitattributes#L25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
