harshmotw-db opened a new pull request, #50823:
URL: https://github.com/apache/spark/pull/50823
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Instead of checking `requiredAttrSet.contains(attr)`, this PR proposes that
we also verify the count of these attributes.
### Why are the changes needed?
Sometimes, one of the child's attribute's could be more frequent in the
input than the output but all the copies would pass through resulting in an
assertion failure in Codegen. In interpreted mode, we see incorrect results.
This is a repro which fails in codegen but returns `{null, null}` as opposed to
`{1, 1}` in interpreted mode:
```
sql("""create or replace temporary function spark_func (params
array<struct<x int, y int>>)
| returns STRUCT<a: int, b: int> LANGUAGE SQL
| return (select ns from (
| SELECT try_divide(SUM(item.x * item.y), SUM(item.x * item.x))
AS beta1,
| NAMED_STRUCT('a', beta1,'b', beta1) ns
| FROM (SELECT params) LATERAL VIEW EXPLODE(params) AS item
LIMIT 1));""".stripMargin)
sql("""select spark_func(collect_list(NAMED_STRUCT('x', 1, 'y', 1))) as
result;""").collect()
```
### Does this PR introduce _any_ user-facing change?
Yes, described above.
### How was this patch tested?
Unit tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
