harshmotw-db commented on code in PR #50823:
URL: https://github.com/apache/spark/pull/50823#discussion_r2079050197
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala:
##########
@@ -87,7 +106,7 @@ case class GenerateExec(
val rows = if (requiredChildOutput.nonEmpty) {
val pruneChildForResult: InternalRow => InternalRow =
- if (child.outputSet == AttributeSet(requiredChildOutput)) {
Review Comment:
I'm arguing that we shouldn't compare the two sets. Just because the two
sets have the same attributes doesn't mean that we can just forward the input
as identity. If the counts of the attributes are different, it needs to be
considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
