AveryQi115 commented on code in PR #50822:
URL: https://github.com/apache/spark/pull/50822#discussion_r2078789713
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala:
##########
@@ -75,18 +76,35 @@ abstract class PlanExpression[T <: QueryPlan[_]] extends
Expression {
*/
abstract class SubqueryExpression(
plan: LogicalPlan,
- outerAttrs: Seq[Expression],
+ outerAttrs: Seq[(Expression, Boolean)],
Review Comment:
If you mean that attr2 can be AttributeReference and attr1 can be
OuterReference(attr1), it's not that clear comparing to boolean flags. And
later in the optimizer, we have stripOuterReference process for the
SubqueryExpression and also we have checks to see if a expression/plan have
OuterReference to decide whether the subquery plan is correlated but not
processed or not. Having additional OuterWrapper in the SubqueryExpression is
very misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
