mihailotim-db commented on code in PR #50822:
URL: https://github.com/apache/spark/pull/50822#discussion_r2078919490
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/FunctionTableSubqueryArgumentExpression.scala:
##########
@@ -78,28 +80,37 @@ case class FunctionTableSubqueryArgumentExpression(
"WITH SINGLE PARTITION is mutually exclusive with PARTITION BY")
override def dataType: DataType = plan.schema
+
override def nullable: Boolean = false
+
override def withNewPlan(plan: LogicalPlan):
FunctionTableSubqueryArgumentExpression =
copy(plan = plan)
- override def withNewOuterAttrs(outerAttrs: Seq[Expression])
+
+ override def withNewOuterAttrs(outerAttrs: Seq[(Expression, Boolean)])
: FunctionTableSubqueryArgumentExpression = copy(outerAttrs = outerAttrs)
+
override def hint: Option[HintInfo] = None
+
override def withNewHint(hint: Option[HintInfo]):
FunctionTableSubqueryArgumentExpression =
copy()
+
override def toString: String = s"table-argument#${exprId.id}
$conditionString"
+
override lazy val canonicalized: Expression = {
FunctionTableSubqueryArgumentExpression(
plan.canonicalized,
- outerAttrs.map(_.canonicalized),
+ outerAttrs.map {case (expr, b) => (expr.canonicalized, b)},
Review Comment:
Let's not use `b`, but give it a meaningful name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
