szehon-ho commented on code in PR #50864:
URL: https://github.com/apache/spark/pull/50864#discussion_r2085719506


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/ColumnDefinition.scala:
##########
@@ -233,4 +246,13 @@ case class DefaultValueExpression(
     case _ =>
       throw QueryCompilationErrors.defaultValueNotConstantError(statement, 
colName, originalSQL)
   }
+
+  // Convert the default expression to DefaultValue, which is required by DS 
v2 APIs.
+  def toV2CurrentDefault(statement: String, colName: String): DefaultValue = 
child match {

Review Comment:
   "Alter table alter column" doesnt change 'exists default', so we can use the 
narrower 'DefaultValue' class here that doesnt have that field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to