cloud-fan commented on code in PR #50864:
URL: https://github.com/apache/spark/pull/50864#discussion_r2087360291
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -5243,11 +5243,11 @@ class AstBuilder extends DataTypeAstBuilder
} else {
None
}
- val setDefaultExpression: Option[String] =
+ val setDefaultExpression: Option[DefaultValueExpression] =
if (action.defaultExpression != null) {
-
Option(action.defaultExpression()).map(visitDefaultExpression).map(_.originalSQL)
+ Option(action.defaultExpression()).map(visitDefaultExpression)
} else if (action.dropDefault != null) {
- Some("")
+ Some(DefaultValueExpression(Literal(""), ""))
Review Comment:
shall we use `DefaultValueExpression(null, "")` to indicate dropping default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
