Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6205#discussion_r31829526
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala ---
    @@ -182,3 +185,130 @@ private[spark] object RpcAddress {
         RpcAddress(host, port)
       }
     }
    +
    +
    +/**
    + * An exception thrown if RpcTimeout modifies a [[TimeoutException]].
    + */
    +private[rpc] class RpcTimeoutException(message: String)
    +  extends TimeoutException(message)
    --- End diff --
    
    I just realized that `TimeoutException` doesn't allow you to specify the 
original cause.  This is a little unfortunate, because it means all the stack 
traces will end where we create this class.  It looks like there is an 
`initCause` method which does what we want though.  So I think the constructor 
should require a `cause: TimeoutException`, which we set via `initCause`.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to