mihailom-db commented on code in PR #51117:
URL: https://github.com/apache/spark/pull/51117#discussion_r2135468278
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala:
##########
@@ -258,12 +258,18 @@ object RewriteDistinctAggregates extends
Rule[LogicalPlan] {
def patchAggregateFunctionChildren(
af: AggregateFunction)(
attrs: Expression => Option[Expression]): AggregateFunction = {
- val newChildren = af.children.map(c => attrs(c).getOrElse(c))
+ val newChildren = af.children.map {
+ case so: SortOrder =>
Review Comment:
So is SortOrder the only expression that should propagate into child's child?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
