uros-db commented on code in PR #51117:
URL: https://github.com/apache/spark/pull/51117#discussion_r2135482442
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala:
##########
@@ -258,12 +258,18 @@ object RewriteDistinctAggregates extends
Rule[LogicalPlan] {
def patchAggregateFunctionChildren(
af: AggregateFunction)(
attrs: Expression => Option[Expression]): AggregateFunction = {
- val newChildren = af.children.map(c => attrs(c).getOrElse(c))
+ val newChildren = af.children.map {
+ case so: SortOrder =>
Review Comment:
Yes, this is the only one that I'm aware of, with respect to aggregate
patching. Note that the issue originally came up with `ListAgg` - which is a
bit of a specific aggregate expression. I don't think that we're aware of any
other similar issues at this time, but please feel free to share any additional
info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
