zhztheplayer commented on code in PR #51183:
URL: https://github.com/apache/spark/pull/51183#discussion_r2149321604
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala:
##########
@@ -66,9 +65,6 @@ trait ColumnarToRowTransition extends UnaryExecNode
* [[MapPartitionsInRWithArrowExec]]. Eventually this should replace those
implementations.
*/
case class ColumnarToRowExec(child: SparkPlan) extends ColumnarToRowTransition
with CodegenSupport {
- // supportsColumnar requires to be only called on driver side, see also
SPARK-37779.
- assert(Utils.isInRunningSparkTask || child.supportsColumnar)
Review Comment:
Short answer would be no... The story is that this in-task check was
introduced in https://github.com/apache/spark/pull/35058 to skip the assertion
on executor side to solve another issue. So this PR's change equates to
skipping the assertion on driver side as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
