zhztheplayer commented on code in PR #51183:
URL: https://github.com/apache/spark/pull/51183#discussion_r2150675313
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala:
##########
@@ -66,9 +65,6 @@ trait ColumnarToRowTransition extends UnaryExecNode
* [[MapPartitionsInRWithArrowExec]]. Eventually this should replace those
implementations.
*/
case class ColumnarToRowExec(child: SparkPlan) extends ColumnarToRowTransition
with CodegenSupport {
- // supportsColumnar requires to be only called on driver side, see also
SPARK-37779.
- assert(Utils.isInRunningSparkTask || child.supportsColumnar)
Review Comment:
The need of clarification here might be related to the original writing of
the code. we can think about its equivalence:
```scala
if (!Utils.isInRunningSparkTask) {
// When we are on Spark driver, do the following assertion:
assert(child.supportsColumnar)
}
```
Once we are removing the inner assertion, we can just remove the whole if
block instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
