urosstan-db commented on code in PR #50921: URL: https://github.com/apache/spark/pull/50921#discussion_r2194748951
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ########## @@ -1698,6 +1698,14 @@ object SQLConf { .booleanConf .createWithDefault(!Utils.isTesting) + val DATA_SOURCE_V2_JOIN_PUSHDOWN = + buildConf("spark.sql.optimizer.datasourceV2JoinPushdown") Review Comment: Let's use SQL Conf which will prevent execution of any code on join pushdown path, it is real comparison of join pushdown vs no join pushdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org