cloud-fan commented on code in PR #50921: URL: https://github.com/apache/spark/pull/50921#discussion_r2195054967
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCScanBuilder.scala: ########## @@ -194,4 +304,13 @@ case class JDBCScanBuilder( JDBCScan(JDBCRelation(schema, parts, jdbcOptions)(session), finalSchema, pushedPredicate, pushedAggregateList, pushedGroupBys, tableSample, pushedLimit, sortOrders, pushedOffset) } + +} + +object JoinPushdownAliasGenerator { + private val subQueryId = new java.util.concurrent.atomic.AtomicLong() Review Comment: It's fine, attribute ids are also globally unique but technically they only need to be unique within a query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org