grundprinzip commented on code in PR #152:
URL: https://github.com/apache/spark-connect-go/pull/152#discussion_r2203489075
##########
spark/client/base/base.go:
##########
@@ -48,5 +48,6 @@ type SparkConnectClient interface {
type ExecuteResponseStream interface {
ToTable() (*types.StructType, arrow.Table, error)
+ ToRecordBatches(ctx context.Context) (<-chan arrow.Record, <-chan
error, *types.StructType)
Review Comment:
Would be good to add comments on the how this is intended to be used and
what the difference to the `ToTable` is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
