grundprinzip commented on code in PR #152:
URL: https://github.com/apache/spark-connect-go/pull/152#discussion_r2203488989
##########
spark/client/client.go:
##########
@@ -368,6 +368,15 @@ func (c *ExecutePlanClient) ToTable() (*types.StructType,
arrow.Table, error) {
c.done = false
for {
resp, err := c.responseStream.Recv()
+ if err != nil {
+ fmt.Printf("DEBUG: Recv error: %v, is EOF: %v\n", err,
errors.Is(err, io.EOF))
+ }
+ if err == nil && resp != nil {
+ fmt.Printf("DEBUG: Received response type: %T\n",
resp.ResponseType)
+ if _, ok :=
resp.ResponseType.(*proto.ExecutePlanResponse_ResultComplete_); ok {
+ fmt.Println("DEBUG: Got ResultComplete!")
+ }
+ }
Review Comment:
Yeah, conceptually it would be better to add them to the appropriate client
for example. In Spark 3.4 the stream was blocking and in 4.0 the stream by
default is re-attacheable and the client has a specific implementation for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
