dylanwong250 commented on code in PR #51484:
URL: https://github.com/apache/spark/pull/51484#discussion_r2211685908
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -802,9 +806,7 @@ case class StateStoreId(
}
override def toString: String = {
- s"""StateStoreId[ checkpointRootLocation=$checkpointRootLocation,
operatorId=$operatorId,
- | partitionId=$partitionId, storeName=$storeName ]
- |""".stripMargin.replaceAll("\n", "")
+ s"StateStoreId[ operatorId=$operatorId, partitionId=$partitionId,
storeName=$storeName ]"
Review Comment:
I do not have a strong opinion, but I would prefer not to have separate
methods for logging. I am not very familiar with debugging this part of the
codebase, but I cannot think of a case where this would be needed without also
being needed in a log. Thoughts? @liviazhu @anishshri-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
