micheal-o commented on code in PR #51484:
URL: https://github.com/apache/spark/pull/51484#discussion_r2211698670


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -90,7 +90,7 @@ private[sql] class HDFSBackedStateStoreProvider extends 
StateStoreProvider with
     override def abort(): Unit = {}
 
     override def toString(): String = {
-      
s"HDFSReadStateStore[id=(op=${id.operatorId},part=${id.partitionId}),dir=$baseDir]"
+      s"HDFSReadStateStore[stateStoreProviderId=$stateStoreProviderId]"

Review Comment:
   `HDFSBackedReadStateStore` is not a subclass of 
`HDFSBackedStateStoreProvider`. Using the provider id in the string 
representation of the store instead of the store id isn't correct. State stores 
are identified by storeid and providers are identified by providerid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to