zeroshade commented on code in PR #152:
URL: https://github.com/apache/spark-connect-go/pull/152#discussion_r2225847257
##########
spark/sql/dataframe.go:
##########
@@ -213,6 +213,7 @@ type DataFrame interface {
Take(ctx context.Context, limit int32) ([]types.Row, error)
// ToArrow returns the Arrow representation of the DataFrame.
ToArrow(ctx context.Context) (*arrow.Table, error)
+ ToLocalIterator(ctx context.Context) (types.RowIterator, error)
Review Comment:
I would be in favor of using `iter.Seq` and `iter.Seq2`
For reference, Arrow also allows using `iter` directly:
https://pkg.go.dev/github.com/apache/arrow-go/v18/arrow/array#IterFromReader
and https://pkg.go.dev/github.com/apache/arrow-go/v18/arrow/array#ReaderFromIter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
