zeroshade commented on code in PR #152:
URL: https://github.com/apache/spark-connect-go/pull/152#discussion_r2225855507
##########
spark/client/base/base.go:
##########
@@ -48,5 +48,6 @@ type SparkConnectClient interface {
type ExecuteResponseStream interface {
ToTable() (*types.StructType, arrow.Table, error)
+ ToRecordBatches(ctx context.Context) (<-chan arrow.Record, <-chan
error, *types.StructType)
Review Comment:
Rather than exposing a channel directly, it might make more sense to use
either an `array.RecordReader` or an `iter.Seq2[arrow.Record, error]`.
Either that, or create something that wraps the two channels and produces
one of those, simply to make it easier to consume for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
