Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6684#discussion_r31869068
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala
 ---
    @@ -179,7 +179,7 @@ abstract class GeneralizedLinearAlgorithm[M <: 
GeneralizedLinearModel]
        */
       def run(input: RDD[LabeledPoint]): M = {
         if (numFeatures < 0) {
    -      numFeatures = input.map(_.features.size).first()
    +      numFeatures = input.first().features.size
    --- End diff --
    
    It would only evaluate one element in this case. first() accesses the first 
partition and first element of its iterator, so map should only be applied once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to