Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6684#discussion_r31869377
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala
---
@@ -179,7 +179,7 @@ abstract class GeneralizedLinearAlgorithm[M <:
GeneralizedLinearModel]
*/
def run(input: RDD[LabeledPoint]): M = {
if (numFeatures < 0) {
- numFeatures = input.map(_.features.size).first()
+ numFeatures = input.first().features.size
--- End diff --
You could double-check with a very quick/small benchmark to see if it is in
fact evaluated that way and if there is much difference at all. I suspect both
are OK and don't know which is better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
