ericm-db commented on code in PR #52018:
URL: https://github.com/apache/spark/pull/52018#discussion_r2277089669
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -767,7 +767,9 @@ private[sql] class RocksDBStateStoreProvider
}
override def close(): Unit = {
- rocksDB.close()
+ if (stateMachine.close()) {
+ rocksDB.close()
+ }
Review Comment:
Good question. Basically stateMachine.close() returns a Boolean of whether
we've already closed this instance or not. Having this check keeps us from
double closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
