dongjoon-hyun commented on code in PR #52018:
URL: https://github.com/apache/spark/pull/52018#discussion_r2277089862


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreLockHardeningSuite.scala:
##########
@@ -620,6 +620,175 @@ class RocksDBStateStoreLockHardeningSuite extends 
SparkFunSuite
     }
   }
 
+  test("lock hardening: safe provider close during concurrent commit 
operations") {

Review Comment:
   According to the following Apache Spark guideline, please consider to use a 
test case prefix for the bug fix test case, @ericm-db and @anishshri-db . IIRC, 
this was suggested from Databricks . 😄 
   
   > Also, you should consider writing a JIRA ID in the tests when your pull 
request targets to fix a specific issue.
   
   https://spark.apache.org/contributing.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to