ForVic commented on code in PR #51396: URL: https://github.com/apache/spark/pull/51396#discussion_r2299677101
########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala: ########## @@ -444,6 +444,17 @@ private[spark] object Config extends Logging { .stringConf .createWithDefault("direct") + val KUBERNETES_EXECUTOR_POD_SNAPSHOT_SOURCES = + ConfigBuilder("spark.kubernetes.executor.pod.snapshotSources") + .doc("Class names of pod snapshot sources implementing " + + "ExecutorPodsCustomSnapshotSource. This is a developer API. Comma separated. " + + "If not specified, the default snapshot sources, ExecutorPodsWatchSnapshotSource" + + "and ExecutorPodsPollingSnapshotSource are used.") Review Comment: You mean `createWithDefault(org.apache.spark.scheduler.cluster.k8s.ExecutorPodsPollingSnapshotSource,org.apache.spark.scheduler.cluster.k8s.ExecutorPodsWatchSnapshotSource`? I can update to use that instead. This makes it simpler during cluster manager initialization of these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org