ForVic commented on code in PR #51396:
URL: https://github.com/apache/spark/pull/51396#discussion_r2305233061
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -444,6 +444,17 @@ private[spark] object Config extends Logging {
.stringConf
.createWithDefault("direct")
+ val KUBERNETES_EXECUTOR_POD_SNAPSHOT_SOURCES =
+ ConfigBuilder("spark.kubernetes.executor.pod.snapshotSources")
+ .doc("Class names of pod snapshot sources implementing " +
+ "ExecutorPodsCustomSnapshotSource. This is a developer API. Comma
separated. " +
+ "If not specified, the default snapshot sources,
ExecutorPodsWatchSnapshotSource" +
+ "and ExecutorPodsPollingSnapshotSource are used.")
Review Comment:
Thinking about this a little more:
If we update to use that default then we have to modify the existing classes
`ExecutorPodsWatchSnapshotSource and ExecutorPodsPollingSnapshotSource` to use
no constructor, and be initialized with `.init()`. It would also require some
reworking to allow passing in a DeterministicScheduler to the polling snapshot
source too for testing, similar to what we do with
`ExecutorPodsListerSnapshotSource`. Considering that we mark both the existing
sources as `@Stable`, I feel it would be better to leave it as it is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
