dongjoon-hyun commented on code in PR #298:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/298#discussion_r2306039549
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java:
##########
@@ -334,6 +334,30 @@ public final class SparkOperatorConf {
.defaultValue(19090)
.build();
+ public static final ConfigOption<Boolean>
ENABLE_PROMETHEUS_TEXT_BASED_FORMAT =
+ ConfigOption.<Boolean>builder()
+
.key("spark.kubernetes.operator.metrics.enablePrometheusTextBasedFormat")
Review Comment:
For new configuration, we had better rename `enableXXX` to `XXXEnabled` for
consistency.
```
- spark.kubernetes.operator.metrics.enablePrometheusTextBasedFormat
+ spark.kubernetes.operator.metrics.PrometheusTextBasedFormatEnabled
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
